OS4.1FEu2 release breaks plugin loading Hollywood pre 8.x

[lazi]

It seems to me that something breaks older Hollywood executables in the latest OS4 update.
The symptom is that programs doesn't starts and complaining missing plugin files.

Recompiling the scripts with 8.0 and problems are gone.
Unfortunately there are executables in the wild which stops working from this time.
If it is an OS bug it would be worth to find.

Tried to revert back to Hollywood 7.0 system and here is what I found.

Any compiling gives this log:

Code: Select all

Hollywood 7.0 [AmigaOS4] [32-bit] (c) by Andreas Falkenhahn
The Cross-Platform Multimedia Application Layer
 
Licenced to xy 
 
Loading plugin svgimage.hwp...failed
(Reason: Error loading plugin "svgimage.hwp"!)
Loading plugin sid.hwp...failed
(Reason: Error loading plugin "sid.hwp"!)
Loading plugin rebelsdl.hwp...failed
(Reason: Error loading plugin "rebelsdl.hwp"!)
Loading plugin vectorgraphics.hwp...failed
(Reason: Error loading plugin "vectorgraphics.hwp"!)
Loading plugin ppunpack.hwp...failed
(Reason: Error loading plugin "ppunpack.hwp"!)
Loading plugin polybios.hwp...failed
(Reason: Error loading plugin "polybios.hwp"!)
Loading plugin hurl.hwp...failed
(Reason: Error loading plugin "hurl.hwp"!)
Loading plugin zip.hwp...failed
(Reason: Error loading plugin "zip.hwp"!)
Loading plugin rapagui.hwp...failed
(Reason: Error loading plugin "rapagui.hwp"!)
Loading plugin oggvorbis.hwp...failed
(Reason: Error loading plugin "oggvorbis.hwp"!)
Loading plugin glgalore.hwp... 

The snoopy output parallell with the compiling:

Code: Select all

00242 : Hollywood       : o.k. = Lock("LIBS:Hollywood",SHARED) [120uS]
00243 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AAC8,256,0x00000100) [82uS]
00244 : Hollywood       : o.k. = ObtainDirContext(ctx=0x6FCB1238  dflags=0xFFFF) = [0x6FCB1238] [68uS]
00245 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [81uS]
00246 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [85uS]
00247 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [318uS]
00248 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/svgimage.hwp") = [0x19525BE1] [174477uS]
00249 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [293uS]
00250 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A808,256,0x00000100) [309uS]
00251 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [300uS]
00252 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [84uS]
00253 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [66uS]
00254 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [88uS]
00255 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [306uS]
00256 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/sid.hwp") = [0x19525B61] [2294uS]
00257 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [290uS]
00258 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A808,256,0x00000100) [308uS]
00259 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [305uS]
00260 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [115uS]
00261 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [312uS]
00262 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/rebelsdl.hwp") = [0x19525B81] [3289uS]
00263 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [284uS]
00264 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A808,256,0x00000100) [352uS]
00265 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [410uS]
00266 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [412uS]
00267 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [490uS]
00268 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/vectorgraphics.hwp") = [0x19525BB1] [89494uS]
00269 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [282uS]
00270 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A808,256,0x00000100) [330uS]
00271 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [304uS]
00272 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [104uS]
00273 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [302uS]
00274 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/ppunpack.hwp") = [0x19525911] [2130uS]
00275 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [287uS]
00276 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A808,256,0x00000100) [308uS]
00277 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [300uS]
00278 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [111uS]
00279 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [298uS]
00280 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/polybios.hwp") = [0x19525BE1] [66569uS]
00281 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [287uS]
00282 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A808,256,0x00000100) [306uS]
00283 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [298uS]
00284 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [86uS]
00285 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [94uS]
00286 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [294uS]
00287 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/hurl.hwp") = [0x19525B71] [88961uS]
00288 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [288uS]
00289 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A808,256,0x00000100) [310uS]
00290 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [293uS]
00291 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [104uS]
00292 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [300uS]
00293 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/zip.hwp") = [0x19525811] [46505uS]
00294 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [292uS]
00295 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A808,256,0x00000100) [306uS]
00296 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [298uS]
00297 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [106uS]
00298 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [298uS]
00299 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/rapagui.hwp") = [0x19525B81] [68929uS]
00300 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [305uS]
00301 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A808,256,0x00000100) [311uS]
00302 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [356uS]
00303 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [656uS]
00304 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [375uS]
00305 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/oggvorbis.hwp") = [0x19525B61] [17737uS]
00306 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [1863uS]
00307 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A808,256,0x00000100) [390uS]
00308 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4B278,256,0x00000100) [398uS]
00309 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4A3C8,256,0x00000100) [392uS]
00310 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA48,256,0x00000100) [400uS]
00311 : Hollywood       : o.k. = LoadSeg("LIBS:Hollywood/glgalore.hwp") = [0x19525B91] [60080uS]
00312 : Hollywood       : FAIL = GetVar("codeset_default",0x64A4AA18,256,0x00000100) [15990uS]

[airsoftsoftwair]

Yeah, this is because the OS4 developers decided to break compatibility in dos.library's LoadSeg(). I've adapted Hollywood to work correctly with the new LoadSeg() in Hollywood 7.1 but of course it means that all executables compiled by Hollywood < 7.1 won't be able to load plugins on OS4. Not my fault, though...

Here's the "fix" in Hollywood 7.1:

Code: Select all

- Fix [OS4/GUI]: Fixed plugin loader to be compatible with dos.library v54.40 and up; this was
  necessary because of a compatibility break in OS4 DOS

[lazi]

Ahh, at last we know what that history entry really means!

Was the reason is violating this?

NAME
LoadSeg -- Loads a loadable file into memory. (68K or NATIVE)
...
WARNING
Never assume what the result of this function represents.
You must use IDOS->GetSegListInfo() to determine the actual construct.
Directly converting the BPTR to anything can break your application
in future updates or when additional new formats are supported.

[airsoftsoftwair]

No, Hollywood was using GetSegListInfo() before 7.1 as well. They changed something in GetSegListInfo() which breaks all those executables...